Skip to content

Add collapsible to improve readability #370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 25, 2022

Conversation

EDDYMENS
Copy link
Contributor

@EDDYMENS EDDYMENS commented Jun 9, 2022

Wrapped the dumped structure objects in a collapsible to make ReadMe easier to read.

Copy link
Collaborator

@oliverklee oliverklee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the change a lot!

I've left two comments on Markdown formatting nitpicks.

@@ -606,6 +613,8 @@ class Sabberworm\CSS\CSSList\Document#4 (2) {
}

```
</details>

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ditto.

@sabberworm
Copy link
Collaborator

Thanks. I like the increased usability this brings but I worry “Click to expand” is not a title saying much. Would it be possible to use the preceding h4 as a summary?

@EDDYMENS
Copy link
Contributor Author

@sabberworm good idea! Using the h4 tag pushes the text to the next line so I used <b> instead and also <code> for highlighting since the backtick ` won't work in this case as well.
Let me know if this is ok

@sabberworm sabberworm merged commit e4191b2 into MyIntervals:master Jun 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants